-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.x DRAFT #222
Merged
Merged
v5.x DRAFT #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwhitley
added
new feature
New feature or request
in progress
I'm working on it... allegedly...
Feedback Requested
API Changes, interface questions, etc...
labels
Mar 15, 2024
kwhitley
changed the title
4.3x - FlowRouter + AutoRouter
DRAFT: 4.3x - FlowRouter + AutoRouter
Mar 15, 2024
This was referenced Mar 15, 2024
kwhitley
changed the title
DRAFT: 4.3x - FlowRouter + AutoRouter
DRAFT: 4.3x - IttyRouter + Router + AutoRouter
Mar 15, 2024
kwhitley
changed the title
DRAFT: 4.3x - IttyRouter + Router + AutoRouter
4.3x Draft: IttyRouter + Router + AutoRouter
Mar 19, 2024
kwhitley
changed the title
4.3x Draft: IttyRouter + Router + AutoRouter
4.3x DRAFT: IttyRouter + Router + AutoRouter
Mar 19, 2024
* replaced after stage with finally * fixed potential bug in createResponse to prevent pollution if passed a Request as second param, like in v4.3 stages * createResponse simplified and safe against using as ResponseHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feedback Requested
API Changes, interface questions, etc...
in progress
I'm working on it... allegedly...
new feature
New feature or request
PENDING RELEASE
Final stages before release! :D
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Progress
Changes
Router
(adding features) ~550 bytesrouter.fetch
signature to match up to various runtimes (e.g. Bun, Cloudflare Workers). We also make the possibility ofAutoRouter
that adds sane defaults. Previously, this control flow was only possible using the.then
chain afterrouter.fetch
, or by monkey-patching/intercepting the fetch method itself.Router
(nowIttyRouter
)before
- array of before handlers/middlewarecatch
- a single error handler to catch thrown exceptionsfinally
- array of response handlersafter
handler is passed the following args:(response: any, request: IRequest, ...args)
, where...args
are anything additional passed to the originalfetch
function. This allows theafter
stage to easily have access to Cloudflare environment and context.Example:
AutoRouter
(new) ~1kBRouter
with sane defaults and a few modified behaviorsformat
(a single response formatter, such asjson
) to control default formatterformat: () => {}
missing
(a single request handler that will be passed the request and any additional args)missing: () => {}
before
stage entryfinally
always uses the following pattern:Example:
IttyRouter
(new) ~460 bytesRouter
toIttyRouter
.handle
is fully deprecated here (in favor ofrouter.fetch
) to save bytesExample:
Type of Change (select one and follow subtasks)